Move from custom DALI conda recipe to upstream nvidia-dali-feedstock - #6402
Move from custom DALI conda recipe to upstream nvidia-dali-feedstock#6402JanuszL wants to merge 10 commits into
Conversation
|
CI MESSAGE: [55681719]: BUILD STARTED |
|
| Filename | Overview |
|---|---|
| conda/build_conda_packages.sh | Rewritten to use rattler-build + upstream feedstock; adds explicit input validation, patch --check guard, and grep verifications for every sed substitution. All previously-flagged issues are addressed. |
| conda/nvidia-dali-python-feedstock.patch | New patch file: removes release-tarball sources/sha256/patches, adds rm-rf cleanup before symlink creation, enables BUILD_FOR_CONDA/BUILD_TEST/BUILD_BENCHMARK, bumps libnvimgcodec 0.8 to 0.9 across all CI support YAMLs, and injects DALI version/flavor env vars into recipe.yaml context. |
| conda/config/conda_build_config.yaml | Deleted; equivalent configuration now lives in the upstream feedstock's recipe/conda_build_config.yaml (patched by nvidia-dali-python-feedstock.patch). |
| conda/dali_native_libs/recipe/build.sh | Deleted; CMake invocation logic moved to the upstream feedstock's build.sh (with DALI-specific flags injected via the patch file). |
| conda/dali_native_libs/recipe/meta.yaml | Deleted; dependency pinnings and package metadata now managed by the upstream feedstock recipe. |
| conda/dali_python_bindings/recipe/build.sh | Deleted; Python bindings build logic is handled by the upstream feedstock. |
| conda/dali_python_bindings/recipe/meta.yaml | Deleted; Python bindings package metadata now managed by the upstream feedstock recipe. |
| conda/dali_native_libs/recipe/activate.d/nvimgcodec_extensions_path.sh | Deleted; nvimgcodec extensions-path workaround activate hook removed along with the old recipe. |
| conda/dali_native_libs/recipe/deactivate.d/nvimgcodec_extensions_path.sh | Deleted; counterpart deactivate hook for the nvimgcodec extensions-path workaround removed. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[build_conda_packages.sh] --> B{Validate inputs}
B -->|invalid| ERR1[exit 1]
B -->|valid| C[Select METAL_YAML]
C --> D[git clone feedstock]
D --> E{DALI_FEEDSTOCK_SHA set?}
E -->|yes| F[git checkout SHA]
E -->|no| G[use HEAD]
F --> H[git apply --check patch]
G --> H
H -->|fail| ERR2[exit 1]
H -->|OK| I[git apply patch]
I --> J[sed: URL to local path]
J --> K{grep verify}
K -->|fail| ERR3[exit 1]
K -->|OK| L[sed: use_gitignore false]
L --> M{grep verify}
M -->|fail| ERR4[exit 1]
M -->|OK| N[rattler-build build]
N --> O[Copy artifacts]
Reviews (16): Last reviewed commit: "Update conda CI nvImageCodec pins" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
957c7ca to
714dac3
Compare
714dac3 to
dd7d6ca
Compare
|
CI MESSAGE: [55681719]: BUILD FAILED |
dd7d6ca to
8fa4e57
Compare
|
CI MESSAGE: [55685089]: BUILD STARTED |
|
CI MESSAGE: [55685089]: BUILD FAILED |
8fa4e57 to
f63cb59
Compare
|
CI MESSAGE: [55688559]: BUILD STARTED |
|
CI MESSAGE: [55688559]: BUILD FAILED |
|
CI MESSAGE: [55693916]: BUILD STARTED |
|
CI MESSAGE: [55694466]: BUILD STARTED |
|
CI MESSAGE: [55696184]: BUILD STARTED |
3e8800a to
a5acefb
Compare
|
CI MESSAGE: [57832399]: BUILD STARTED |
|
CI MESSAGE: [57832399]: BUILD FAILED |
a5acefb to
86ccb4a
Compare
|
CI MESSAGE: [57957810]: BUILD STARTED |
|
CI MESSAGE: [57957810]: BUILD FAILED |
|
CI MESSAGE: [57967556]: BUILD STARTED |
|
CI MESSAGE: [57967556]: BUILD FAILED |
86ccb4a to
536c992
Compare
|
CI MESSAGE: [58002631]: BUILD STARTED |
|
CI MESSAGE: [58002631]: BUILD FAILED |
|
CI MESSAGE: [58105433]: BUILD STARTED |
|
CI MESSAGE: [58105433]: BUILD FAILED |
|
CI MESSAGE: [58114829]: BUILD STARTED |
|
CI MESSAGE: [58114829]: BUILD PASSED |
f29a40a to
72e4bd3
Compare
|
CI MESSAGE: [59219619]: BUILD STARTED |
|
CI MESSAGE: [59219619]: BUILD FAILED |
|
CI MESSAGE: [59248913]: BUILD STARTED |
|
CI MESSAGE: [59248913]: BUILD FAILED |
|
CI MESSAGE: [59272399]: BUILD STARTED |
|
CI MESSAGE: [59272399]: BUILD PASSED |
- uses nvidia-dali-feedstock recipe to build DALI in CI - removes DALI maintained recipe Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
dd2c65d to
2cc9de3
Compare
|
CI MESSAGE: [60894791]: BUILD STARTED |
|
CI MESSAGE: [60894791]: BUILD PASSED |
5 participants
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-4680